Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: split out read config for easier testing #80

Merged
merged 11 commits into from
May 27, 2024
Merged

Conversation

chadsr
Copy link
Owner

@chadsr chadsr commented May 27, 2024

  • Plus more tests

@chadsr chadsr self-assigned this May 27, 2024
Copy link

codecov bot commented May 27, 2024

Codecov Report

Attention: Patch coverage is 91.20000% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 84.73%. Comparing base (426846c) to head (785cd51).
Report is 3 commits behind head on master.

Current head 785cd51 differs from pull request most recent head 3f70cd0

Please upload reports for the commit 3f70cd0 to get more accurate results.

Files Patch % Lines
waybar_crypto.py 81.03% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
- Coverage   86.27%   84.73%   -1.54%     
==========================================
  Files           2        2              
  Lines         255      321      +66     
==========================================
+ Hits          220      272      +52     
- Misses         35       49      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chadsr chadsr merged commit 7ea555e into master May 27, 2024
5 checks passed
@chadsr chadsr deleted the feature/read-config branch May 27, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant